Allow setting the physical extent size for volume groups #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
approved these changes
Mar 7, 2024
|
ah okay, rubocop does not like it |
bastelfreak
reviewed
Mar 7, 2024
| validate do |value| | ||
| raise ArgumentError, "#{value} is not a valid extents size" unless %r{^[0-9]+(\.[0-9]+)?}i.match?(value) | ||
| end | ||
| defaultto 4 |
There was a problem hiding this comment.
is that the actual default in vgcreate? I couldn't find it in the manpage.
There was a problem hiding this comment.
https://linux.die.net/man/8/vgcreate
The default is 4 MiB and it must be at least 1 KiB and a power of 2.
There was a problem hiding this comment.
Could we just omit the -s flag entirely if the parameter isn't specified to truly maintain backwards compatibility?
btw I'm also interested in these updates
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.